containers / virtcontainers

A Go package for building hardware virtualized container runtimes

Apache License 2.0

139 stars 43 forks source link

Revert "Merge pull request #584 from amshinde/switch-to-scsi" #652

Closed sboeuf closed 6 years ago

sboeuf commented 6 years ago

This reverts commit 494b46c5bfa0c305fa3e2ad9d15ca12af2c148a5, reversing changes made to e475a8fcc486f83b1719166aa8e5a936c14f72e5.

THIS IS A TEST PR.

devimc commented 6 years ago

lgtm

jodh-intel commented 6 years ago

Hi @sboeuf - I see that this is a test PR, but please can you explain why this revert is needed? In fact, could you raise an issue with full details?

sboeuf commented 6 years ago

@jodh-intel yes that was a test PR, let me talk with @amshinde before we take a decision about this.

amshinde commented 6 years ago

@jodh-intel We are seeing some random failures with hotplug test for virtio-scsi: https://github.com/clearcontainers/runtime/pull/1039 I'll be taking a look at this today to see what the exact issue is.

amshinde commented 6 years ago

The issue was due to an old version of agent being used in our CI. We can close this now. I have rerun CI for this VC PR: https://github.com/containers/virtcontainers/pull/649 Once that passes, we can close this PR.

sboeuf commented 6 years ago

@amshinde sounds good to me :)

sboeuf commented 6 years ago

649 passed as expected, let's close this then !