docs: Developer: must develop/test in main repo

containers / virtcontainers

A Go package for building hardware virtualized container runtimes

Apache License 2.0

139 stars 43 forks source link

docs: Developer: must develop/test in main repo #653

Closed grahamwhaley closed 6 years ago

grahamwhaley commented 6 years ago

You cannot build and test in a repo fork, as the sub-pkg references do not move with the fork, and we fail due to type difference failures.

Add details on how to add your user fork as a remote to the main repo so you can develop/PR.

Also update details on installing required components into /tmp, and the inherent weakness of that.

Note you need 'CI=true' to usefully run make check.

Fixes: #642

Signed-off-by: Graham whaley graham.whaley@intel.com

grahamwhaley commented 6 years ago

@jodh-intel - updated, pushed.

jodh-intel commented 6 years ago

The only potential issue is the CI=true. So I'd say this is blocked on #654 until we've got agreement on how to use that variable. Aside from that issue,

lgtm

sboeuf commented 6 years ago

@grahamwhaley Need to be closed and moved to https://github.com/kata-containers/runtime/virtcontainers