Closed grahamwhaley closed 6 years ago
Marked as DNM so we can discuss (so really an RFC).
make check
works as beforego test -bench=.
gives the same results as before (see below)I didn't realise we had some benchmarks ;-) I managed to run them with:
$ sudo -E env PATH="$PATH" go test -bench=.
It looks like we may have bitrotted though (as I suspect nobody runs these). The output I have from both the original and the modified-in-this-patch I get is:
Some output on stderrERRO[0004] hook error arch=amd64 error="exit status 1: stdout: , stderr: " hook-type=pre-start source=virtcontainers subsystem=hooks
Some output on stderrBenchmarkCreateStartStopDeletePodQemuHypervisorHyperstartAgentNetworkCNI-4 2 699418793 ns/op
BenchmarkCreateStartStopDeletePodQemuHypervisorNoopAgentNetworkCNI-4 2 552637127 ns/op
BenchmarkCreateStartStopDeletePodQemuHypervisorHyperstartAgentNetworkNoop-4 3 532006579 ns/op
BenchmarkCreateStartStopDeletePodQemuHypervisorNoopAgentNetworkNoop-4 10 251059396 ns/op
BenchmarkCreateStartStopDeletePodMockHypervisorNoopAgentNetworkNoop-4 500 4059463 ns/op
BenchmarkStartStop1ContainerQemuHypervisorHyperstartAgentNetworkNoop-4 2 1117480785 ns/op
BenchmarkStartStop10ContainerQemuHypervisorHyperstartAgentNetworkNoop-4 1 6304859774 ns/op
PASS
ok github.com/containers/virtcontainers 27.195s
@sboeuf - something you think we should fix? Any idea how?
LGTM
Rather than have some of our required test support files live in
/tmp
, let's install them in a local dir instead.