containers / virtcontainers

A Go package for building hardware virtualized container runtimes
Apache License 2.0
139 stars 43 forks source link

qemu: disable modern in SCSI constroller #664

Closed devimc closed 6 years ago

devimc commented 6 years ago

Disable modern to prevent qemu from relying on fast MMIO. This change is needed to avoid boot issues when using virtio-scsi in a nested virtual machine scenario.

fixes #663

Signed-off-by: Julio Montes julio.montes@intel.com

amshinde commented 6 years ago

@devimc dont you need to revendor govmm here?

devimc commented 6 years ago

@sboeuf @amshinde done

sboeuf commented 6 years ago

LGTM

devimc commented 6 years ago

@egernst done

egernst commented 6 years ago

Looks good -- happy to see it merged after the CI finishes up. Thanks @devimc