containers / virtcontainers

A Go package for building hardware virtualized container runtimes
Apache License 2.0
139 stars 43 forks source link

Ignore route with ipv6 gateway #673

Closed amshinde closed 6 years ago

amshinde commented 6 years ago

We ignore routes that have an ipv6 destination, since we do not have support for ipv6 currently. We should do the same for default route that has an ipv6 gateway address.

amshinde commented 6 years ago

@mcastelino @egernst PTAL

mcastelino commented 6 years ago

@chavafg can we enable IPv6 in our docker CI https://docs.docker.com/config/daemon/ipv6/

This will help catch issues easily. We should ignore IPv6 settings till we support them.

amshinde commented 6 years ago

Changes to two different agent implementations, makes sense to have them in a separate commit. We can revert one once we add ipv6 support.

sboeuf commented 6 years ago

@amshinde I don't mind having one or two commits here, but please could you add a subsystem for each of your commit messages, identifying which component is modified: kata_agent: ipv6: ... hyperstart_agent: ipv6: ...

Or simply squash them. Up to you !

amshinde commented 6 years ago

@sboeuf I have modified the commit message.

sboeuf commented 6 years ago

@amshinde LGTM

amshinde commented 6 years ago

@sboeuf I see the fedora CI failing this time, even though I just changed the commit message. http://cc-jenkins-ci.westus2.cloudapp.azure.com/job/virtcontainers-fedora-26-PR/519/console

--- FAIL: TestRunPodHyperstartAgentSuccessful (0.04s)
21:48:14    cc_proxy_mock.go:90: [CCProxyMock] listening on /tmp/cc-proxy-test162776106/cc-proxy-test.sock
21:48:14    cc_proxy_mock.go:90: [CCProxyMock] Client connected
21:48:14    cc_proxy_mock.go:90: [CCProxyMock] Register VM
21:48:14    cc_proxy_mock.go:90: [CCProxyMock] Error serving client : EOF
21:48:14    cc_proxy_mock.go:90: [CCProxyMock] Client closed connection
21:48:14    cc_proxy_mock.go:90: [CCProxyMock] Client connected
21:48:14    cc_proxy_mock.go:90: [CCProxyMock] Attach VM
21:48:14    cc_proxy_mock.go:90: [CCProxyMock] Hyper command
21:48:14    cc_proxy_mock.go:90: [CCProxyMock] Error serving client : EOF
21:48:14    cc_proxy_mock.go:90: [CCProxyMock] Client closed connection
21:48:14    cc_proxy_mock.go:90: [CCProxyMock] Client connected
21:48:14    cc_proxy_mock.go:90: [CCProxyMock] Attach VM
21:48:14    cc_proxy_mock.go:90: [CCProxyMock] Error serving client : EOF
21:48:14    cc_proxy_mock.go:90: [CCProxyMock] Client closed connection
21:48:14    api_test.go:778: Could not bind mount /tmp/virtcontainers-tmp-636974255/bundle to /run/hyper/shared/pods/7f49d00d-1995-4156-8c79-5f5ab24ce138/1/rootfs: no such file or directory

I am going to rerun to see if I get the same error, but maybe a potential bug/race somewhere else in our code.

sboeuf commented 6 years ago

@amshinde some race conditions in our unit tests... I have re-triggered a build already.

jodh-intel commented 6 years ago

lgtm

Approved with PullApprove Approved with PullApprove