search

containers / youki

A container runtime written in Rust
https://containers.github.io/youki/
Apache License 2.0
6.2k stars 337 forks source link

Rust 1.77.1 #2746

Closed utam0k closed 5 months ago

utam0k commented 5 months ago

Hey, otherwise looks ok, but in two files crates/libcgroups/src/lib.rs and tests/contest/contest/src/utils/mod.rs I don't think unused_imports is required? I tried removing them, and for the first file, it worked, and for second, I needed to remove the unused imports, which I think is better.

wdyt?

Thanks for your check. Did you pass all CI?

YJDoc2 commented 5 months ago

For crates/libcgroups/src/lib.rs we need it due to feature test, but I managed to pass CI with removing the extra imports in tests/contest/contest/src/utils/mod.rs. I'll push another commit removing this and merge the PR.

Thanks!