search

containers / youki

A container runtime written in Rust
https://containers.github.io/youki/
Apache License 2.0
6.2k stars 337 forks source link

Init a selinux project #2800

Closed Gekko0114 closed 3 months ago

Gekko0114 commented 4 months ago

This is an experimental crate. I'll implement a selinux crate step-by-step. When it is mature, I'll move it under the 'crate/' and use it. ref: #2718

Gekko0114 commented 4 months ago

@YJDoc2 @utam0k As the initial PR, what function should I implement at least? Or is any small PR fine ?

utam0k commented 4 months ago

I'm not familiar with this area. So, It would be nice if you could make the PR small enough so that one function could run on e2e.

Gekko0114 commented 3 months ago

Sure, thanks!

Gekko0114 commented 3 months ago

Hi @utam0k , @YJDoc2

Though this PR is small, I would like to complete this before becoming too complicated. Could you review it?

utam0k commented 3 months ago

Though this PR is small, I would like to complete this before becoming too complicated. Could you review it?

This PR is the perfect size for me to review! Thanks. But sorry, I'll revisit it next weekend 🙏

Gekko0114 commented 3 months ago

Hi @utam0k, @YJDoc2,

Thanks to your comments, I've fixed this PR. However, I think there are some parts which is not rust-friendly. I would appreciate it if you could let me know.

Gekko0114 commented 3 months ago

@utam0k Thanks! Since I don't have the write access, I can't merge this PR. Could you merge this PR if it is ok?

utam0k commented 3 months ago

Thanks, @Gekko0114 ! Great work!