search

containers / youki

A container runtime written in Rust
https://containers.github.io/youki/
Apache License 2.0
5.99k stars 332 forks source link

change `mount.rs` find_parent_mount from pub to private #2814

Open lengrongfu opened 2 weeks ago

lengrongfu commented 2 weeks ago

The current find_parent_mount method is only in impl Mount use, we can change to private fn from pub fn. https://github.com/containers/youki/blob/4d4ce7c3710d1ed8f155adf23fb62dc672197043/crates/libcontainer/src/rootfs/mount.rs#L614

YJDoc2 commented 2 weeks ago

Note that this change would likely be a breaking change, so PR should be labeled accordingly, along with changelog info.

utam0k commented 2 weeks ago

@Mossaka Do you use this function in runwasi?

Mossaka commented 2 weeks ago

No, it's not used in runwasi. However, I would be more careful in making breaking changes if we don't have a strong motivation.

lengrongfu commented 2 weeks ago

Thanks every body suggestion, we can hold this issue, keep watch, and then decide how to resolve.