containers / youki

A container runtime written in Rust
https://containers.github.io/youki/
Apache License 2.0
6.2k stars 337 forks source link

Add new `setup_envs` method for the `Executor` trait #2820

Closed musaprg closed 3 months ago

musaprg commented 3 months ago

fixes #2815

This PR introduces a new setup_envs method for the Executor trait. It allows any implementors of the Executor trait to control how environment variables specified in the OCI spec are handled. The default implementation mirrors the behavior of the one implemented in the container_init_process, which involves removing existing environment variables and setting the ones specified in the OCI spec.

TODO

utam0k commented 3 months ago

cc: @Mossaka

musaprg commented 3 months ago

@Mossaka @utam0k @jprendes Hi. Thanks for the reviews! I've updated my PR based on your comments. Would you recheck again?

utam0k commented 3 months ago

@musaprg Congrats! 🎉 Thanks for your contribution.