search

containers / youki

A container runtime written in Rust
https://containers.github.io/youki/
Apache License 2.0
5.99k stars 332 forks source link

selinux: write xattr related codes. #2825

Open Gekko0114 opened 1 week ago

Gekko0114 commented 1 week ago

This is an experimental crate. I'll implement a selinux crate step-by-step. In this PR, I implemented functions related to xattr.

ref: https://github.com/containers/youki/issues/2718 https://github.com/containers/youki/pull/2800

Gekko0114 commented 1 week ago

Hi @utam0k, @YJDoc2, I've created this small PR adding the functions related to xattr. Could you review it?

utam0k commented 6 days ago

I'll visit this PR in a couple of days. Please give me some time.

Gekko0114 commented 2 days ago

Hi @utam0k, @YJDoc2, Thanks for your comments and fixed them. Could you take a look again when you have time?

codecov-commenter commented 2 days ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 66.29%. Comparing base (46fb4ba) to head (3123107). Report is 17 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2825 +/- ## ========================================== + Coverage 66.27% 66.29% +0.02% ========================================== Files 131 131 Lines 16784 16794 +10 ========================================== + Hits 11123 11134 +11 + Misses 5661 5660 -1 ```
YJDoc2 commented 2 days ago

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

@utam0k should we remove the codecov bot for now? We are not enforcing the coverage value in CI, and also not maintaining a required threshold for it.