search

containous / traefik-extra-service-fabric

Traefik extra: Service Fabric Provider
Apache License 2.0
12 stars 14 forks source link

Bug: exception occured when a Stateful service does not have a name #22

Closed boreys closed 6 years ago

boreys commented 6 years ago

When there is a Stateful service which does not have a name and Partition ID, $service.Name become an empty string which cause exception. Function getBackendName expect a param of type servicefabric.ServiceItemExtended.

lawrencegripper commented 6 years ago

Hi, Thanks for raising this one - have some time to take a look at this later this week. Do you have an example service that I can use to reproduce this issue? I'm unclear on how you have created a stateful service which doesn't have a partition or name.

@jjcollinge - any ideas here?

jjcollinge commented 6 years ago

Attempting to deploy a service with no name should result in an "Invalid name URI" exception - please can you explain how you are creating a SF without a name? Stateful service partitions (even singleton) should have an identifier - again, please can you clarify how you've ended up with an empty partition ID?

boreys commented 6 years ago

We run Patch Orchestration App that run in the cluster to update OS. This app cause the problem. Without this app Traefik works fine. Or a fix I implement make it work. https://docs.microsoft.com/en-us/azure/service-fabric/service-fabric-patch-orchestration-application

jjcollinge commented 6 years ago

Ok thanks for the clarification @boreys - we will investigate and review your PR as soon as we can.

jjcollinge commented 6 years ago

Hi @boreys - can you send me some details to help me repro:

I've set-up a new SF cluster in Azure with the patch orchestration service and I've not been able to get Traefik to crash. Can you give me as much detail as possible regarding the scenario that causes the failure - is it during an actual update?

ldez commented 6 years ago

Closed in favor of #27