containous / traefik-extra-service-fabric

Traefik extra: Service Fabric Provider
Apache License 2.0
12 stars 14 forks source link

v1.6rc docs reference v1.5 label #31

Closed jjcollinge closed 6 years ago

jjcollinge commented 6 years ago

In the current v1.6rc docs, under the heading extensions the sample for labels references the v1.5 label expose rather than the v1.6 label enable.

<StatelessServiceType ServiceTypeName="WebServiceType">
  <Extensions>
      <Extension Name="Traefik">
        <Labels xmlns="http://schemas.microsoft.com/2015/03/fabact-no-schema">
          <Label Key="traefik.frontend.rule.example2">PathPrefixStrip: /a/path/to/strip</Label>
         <!-- This should be enable -->
         <Label Key="traefik.expose">true</Label>
         <!-- This should be enable -->
          <Label Key="traefik.frontend.passHostHeader">true</Label>
        </Labels>
      </Extension>
  </Extensions>
</StatelessServiceType>
ldez commented 6 years ago

@jjcollinge do you plan to make a PR about this?

jjcollinge commented 6 years ago

Yes, I am travelling so raised this as a reminder to fix when I arrive.