Closed lurock closed 5 years ago
@lurock thanks, it looks good at first glance :). Would it be possible to get some test coverage for this too please?
@lurock Thanks for the PR! This makes sense to me, one tweak I'd propose is maybe moving the label to traefik.servicefabric.endpointname
.
My thinking is that existing SF specific labels sit under .servicefabric
to help users understand they'll be under the SF docs not the generic Traefik docs and as the name
field we're referencing is on the endpoint
object in SF I think it would fits better.
Another tweak we could look at would be elevating some of the logic out of the template into a function in go
, this isn't a deal breaker for me but @ldez may request it.
If you want any pointers on this drop onto the Traefik slack and there is a service-fabric channel, happy to chat/help over IM if that is easier.
I added a test and made the name changes you requested. Is there more changes needed on this PR?
I have been running it in our production cluster for over a week now and it has been working great.
You add a "traefik.portName" label to your Service Fabric manifest and specify the name of the endpoint that you want to serve web traffic through.
Example: