Closed jwlogemann closed 5 years ago
I can confirm that it seems to be working. It is at least both building and running.
For anyone currious why the "netapi32" file is there, it's to fix: https://github.com/golang/go/issues/21867
Any ETA when this is getting merged?
Hi @jwlogemann, thanks for this contribution, it's cool!
This PR is currently being blocked for the following reasons:
netapi32.dll
is missing in the Docker based image of nanoserver, since nanoserver-18.03. This library is required for Traefik (thanks @zlepper to point the thread in golang/go#21867 to us). So this is a dependency for the Windows-based Docker image for Traefik:
nanoserver:sac2016
doesn't for example)Alas, by committing directly the binary as this PR, neither of these 3 elements are fulfilled, which would (at least) make the image refused by Docker when trying to publish it.
What should we do then?
Well, TL;DR; we have to wait for https://github.com/docker-library/official-images/pull/5929 to be ready.
Details:
netapi32.dll
by using a Multi-Stage Docker build.update*.sh
) which download the right Traefik binaries, extracts dependencies for Alpine-based images (certificates) and generates Dockerfiles according to the version of Traefik to be released. This process is run under a Linux machine (Travis, smeaphore, or contributor), so it ain't easy to retrieve the DLL:
docker run/build
to extract the file.skopeo
would be a pain as the Windows image are Gigabytes-sized...Proposal: blocking this PR until Multi-stage build are supported in Docker's official library.
Proposal: blocking this PR until Multi-stage build are supported in Docker's official library.
As docker-library/official-images#5929 has recently been merged, can work on this PR continue? I would really like to see Traefik work on Windows Server 2019!
Yes totally, let's update this PR following the new bashbrew!
I've changed the Dockerfile to be Windows build 1809 compatible. This is needed when using Traefik as a Kubernetes ingress controller in Windows Server 2019
Fixes #44