containous / traefik-library-image

ARCHIVED
https://github.com/traefik/traefik-library-image
Apache License 2.0
218 stars 60 forks source link

Use Multi-Stage Build and add Windows 1809 #58

Closed dduportal closed 5 years ago

dduportal commented 5 years ago

As https://github.com/docker-library/official-images/pull/5929 was merged, and documented here: https://github.com/docker-library/faq#multi-stage-builds, this PR introduces multi-stage build to support a new Windows 1809 image.

This PR fixes #44 , and is a follow-up of #49 (as the author is not responding).

By supporting the brand new multi-stage build, it also supersede #14 and closes #47.

It introduces the following changes (each change is an atomic commit for easier rollback if things go wrong during next release):

Closes #14 Closes #49

dduportal commented 5 years ago

Please note that Windows 1809 is not tested (yet) in AppVeyor, as the environment Windows Server 2019 is currently required. I've requested it to be available here (and on my fork), waiting for this.