search

containrrr / watchtower

A process for automating Docker container base image updates.
https://containrrr.dev/watchtower/
Apache License 2.0
19.4k stars 855 forks source link

Cron expression Format not 6 Fields anymore according to godocs. #398

Open nevotheless opened 5 years ago

nevotheless commented 5 years ago

Describe the bug Check title.

Additional context According to the Watchtower docs: https://containrrr.github.io/watchtower/arguments/#scheduling A 6 Field cron format is getting used but the referenced godoc page https://godoc.org/github.com/robfig/cron#hdr-CRON_Expression_Format also only has 5 fields.

I know that this was different like 1 or 2 weeks ago. Now's the question, is this only a change on the godocs page or is the watchtower cron implementation also affected by this?

welcome[bot] commented 5 years ago

Hi there! Thanks a bunch for opening your first issue! :pray: As you're new to this repo, we'd like to suggest that you read our code of conduct

simskij commented 4 years ago

As we're locking our dependencies to specific commits using go modules, this change has yet to make it to watchtower. I'll go ahead and edit this issue to an improvement suggestion so that we keep it in mind next time we upgrade our dependencies. Thanks a bunch! 🙏🏼

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

simskij commented 4 years ago

This is still an issue we need to address when updating. Reopening.

totti4ever commented 4 years ago

The referenced site now has 6 fields: https://pkg.go.dev/github.com/robfig/cron@v1.2.0?tab=doc#hdr-CRON_Expression_Format

simskij commented 4 years ago

The referenced site now has 6 fields: https://pkg.go.dev/github.com/robfig/cron@v1.2.0?tab=doc#hdr-CRON_Expression_Format

Yes, but it's pointed at the version we're currently using. We should however update our dependencies, and when we do, this will change.