contao-community-alliance / composer-client

This is the Contao Composer Client
http://de.contaowiki.org/Composer
27 stars 18 forks source link

NPM / Bower asset management in Contao / Composer #210

Open tristanlins opened 10 years ago

tristanlins commented 10 years ago

today I read the comments in the composer/composer repository for the topic "bower" support in composer. The following ticket was really interesting: https://github.com/composer/composer/pull/3078

Finally this plugin that support npm and bower was the result of the discussion and development: https://github.com/francoispluchino/composer-asset-plugin

According to our components plugin support, we should also support this plugin and should think about special search modes:

/cc @discordier @frontendschlampe @tim-bec

tim-bec commented 10 years ago

Wow, very interesting approach. double +1 for that

discordier commented 10 years ago

I see a problem with that, namely:

Warning!

Currently the plugin only works in "global" mode, the PR #3082 will allow the plugin to work in "project" mode

That PR is on hold for good reason as it doubles the solving time in composer which already is a big issue for us in shared hosting environment.

Enforcing the installation of this plugin on every instance will most likely be unnecessary for the average user, therefore we might want to add a setting in the expert settings in the like of "enable bower/npm installer" or something like that but most DEFINATELY do not make that the default. At least not for the time being.

tristanlins commented 10 years ago

@discordier yeah, I also read this warning. I cleared the milestone for the moment, lets see what happen with the PR https://github.com/composer/composer/pull/3082 which also solve some issues with our plugin.

francoispluchino commented 10 years ago

If your still interested, a new version of the PR composer/composer#3082 is available.

You can see the details of the operation here.

tristanlins commented 10 years ago

@francoispluchino wow, that sounds great, thx :+1: :-)