fix symlink creation for windows machines and problems with directory separator

contao-community-alliance / composer-plugin

Composer plugin that provide contao integration and installer.

GNU Lesser General Public License v3.0

7 stars 10 forks source link

fix symlink creation for windows machines and problems with directory separator #32

Closed Zeromax closed 10 years ago

Zeromax commented 10 years ago

Fix the symlink generation for Windows Machines.

Take care that Windows XP and older is not supported -> http://de2.php.net/manual/en/function.symlink.php

Note: Windows users should note that this function will only work if the system you run PHP from is Windows Vista/Windows Server 2008 or newer. Windows versions prior to that does not support symbolic links.

discordier commented 10 years ago

@Zeromax @wolfgangwalther Does this also fix #27 or are both changes required?

Zeromax commented 10 years ago

Yes it fixed #27 as well because under Windows I didn't get it work with a relative path.

wolfgangwalther commented 10 years ago

No, this does not fix #27. The result of getSourcesSpec is used in other functions as well, not only in updateAllSymlinks. This PR fixes only part of the symptoms, but not the root cause.