search

contao-community-alliance / composer-plugin

Composer plugin that provide contao integration and installer.
GNU Lesser General Public License v3.0
7 stars 10 forks source link

Fix array arguments on Symfony process #88

Closed bytehead closed 2 years ago

bytehead commented 2 years ago

Fixes #87

bytehead commented 2 years ago

Could possibly, I'll check.

bytehead commented 2 years ago

Changed in 9d5d93f accordingly.

fritzmg commented 2 years ago

This will break compatibility with previous composer versions (and thus possibly also the Contao Manager - not sure though @aschempp).

bytehead commented 2 years ago

@fritzmg You're right, Composer itself ships before 2.3.0 with symfony/process in 2.8.x. I've added a fallback in deed078.

aschempp commented 2 years ago

I think we should go with the setCommandline check. The symfony/process version in the Contao Manager is different from what the pre-build composer.phar contains, since we only support PHP 7.1+ by default. Checking for setCommandline should handle all use cases.

bytehead commented 2 years ago

I don't get the correlation between the argument type hinting and setCommandline? 🤔

fritzmg commented 2 years ago

I don't get the correlation between the argument type hinting and setCommandline? 🤔

The symfony/process version that introduced support for the array argument also introduced that method.

leofeyer commented 2 years ago

We should merge this ASAP, because Contao can no longer be installed with Composer 2.3.