search

contao-community-alliance / contao-multicolumnwizard-bundle

Contao 4 Widget - MultiColumnWizard
GNU Lesser General Public License v3.0
12 stars 12 forks source link

[WIP] Fix generate tableless generation #58

Closed Aziz-JH closed 11 months ago

Aziz-JH commented 5 years ago

If you use generateTableless there is an bug that prevents the fields from being generated.

Aziz-JH commented 5 years ago

ok, there are more problems with the tableless variation. It's not possible to use it. The .js logic is just for the table variation written

https://github.com/menatwork/contao-multicolumnwizard-bundle/blob/8199ad34029a7687c1a4436ae95974fd8dc81e18/src/Resources/public/js/multicolumnwizard_be_src.js#L84

https://github.com/menatwork/contao-multicolumnwizard-bundle/blob/8199ad34029a7687c1a4436ae95974fd8dc81e18/src/Resources/public/js/multicolumnwizard_be_src.js#L322 ...

discordier commented 5 years ago

So this is to be considered to be a WIP and not ready to merge yet.

@Aziz-JH will you continue on this and revamp the JS as well?

Aziz-JH commented 5 years ago

Oh ok, this is WIP. Is a feature brunch for something like this not better? @discordier I can look in to it, but for which case would generateTableless be good?

zonky2 commented 5 years ago

@Aziz-JH may be you change tbody, tr and td as css classes and change the table template - now you can build the same table with div containers

zonky2 commented 4 years ago

@Aziz-JH pls check Travis and change your code