contao-community-alliance / contao-multicolumnwizard-bundle

Contao 4 Widget - MultiColumnWizard
GNU Lesser General Public License v3.0
12 stars 12 forks source link

Ajax Request: ActiveRecord missing options_callback #66

Open dmolineus opened 4 years ago

dmolineus commented 4 years ago

I have a multi column wizard which contains several select fields. All options are computed by an option_callback which relies on the presence of the active record. However, it's missing when a new row is created by the ajax request.

discordier commented 4 years ago

I have never used the activeRecord in MCW myself... what is expected to be contained? I suspect the row values of the current row?

I really wonder if this feature was wildly used and therefore wonder how we shall bring it back (IMO your workaround looks much cleaner).

dmolineus commented 4 years ago

I have never used the activeRecord in MCW myself... what is expected to be contained? I suspect the row values of the current row?

I actually assume the same behaviour af of Contao options_callback. In Contao the data container contains the current record, it would be great to have access to the current record (outside of the multi column wizard).

Having access to the current record id would be enough, the $mcw->id refers to the widget name instead of the id.

I really wonder if this feature was wildly used and therefore wonder how we shall bring it back (IMO your workaround looks much cleaner).

It only works in the edit action and not in the edit all action (in the referenced case edit all is disabled so it work here) but I need a solution to modifiy the options callback depending on the current record to which the mcw belongs to.

zonky2 commented 4 years ago

@dmolineus is this the same as this https://github.com/menatwork/MultiColumnWizard/issues/23 ?

dmolineus commented 4 years ago

@dmolineus is this the same as this menatwork/MultiColumnWizard#23 ?

No, my issue is about a BC break between the mcw and the mcw bundle.

zonky2 commented 4 years ago

... @dmolineus is trying to provide a PR in "next" time