search

contao-community-alliance / dependency-container

Dependency container for Contao Open Source CMS based on the Pimple Dependency Injection Container
GNU Lesser General Public License v3.0
1 stars 4 forks source link

Increase pimple/pimple requirement #20

Open fritzmg opened 4 years ago

fritzmg commented 4 years ago

Is there any chance the requirement for pimple/pimple could be increased? We are using deployer/deployer for our projects as a dev dependency. However, since deployer/deployer requires pimple/pimple: ~3.0 we are unable to install some extensions (or extension versions) which are dependent on contao-community-alliance/dependency-container somewhere down the line.

For example, one can only install menatwork/contao-multicolumnwizard-bundle in version 3.4.0 and not higher, with deployer/deployer also being required. The newest version would be 3.4.4.

Example composer.json:

{
    "require": {
        "contao/manager-bundle": "4.9.*",
        "contao/conflicts": "*@dev",
        "menatwork/contao-multicolumnwizard-bundle": "^3.4"
    },
    "require-dev": {
        "deployer/deployer": "^6.8"
    }
}

This only installs menatwork/contao-multicolumnwizard-bundle in version 3.4.0 instead of 3.4.4.

I am not sure if and what would needed to be adjusted for the higher pimple version though.

discordier commented 4 years ago

This DIC is being phased out and only required for bc reasons by most of our extensions.

zonky2 commented 2 years ago

@fritzmg is this still up to date or can it be closed?

fritzmg commented 2 years ago

I think with the 3.5 release of MCW this issue not is not present anymore (not sure about any other dependents).