Closed dmolineus closed 6 years ago
@dmolineus it´s only for Contao 4.4?
@dmolineus it´s only for Contao 4.4?
Ja.
Adressed all requested changes and add more tests for the multi inheritance features.
@dmolineus could you please have a look on my changes in fca3613, b171d08 and 47d2b7a if I might have broken any of your features?
IMO we should address some things regarding the MetaPalettesBuilder
, it extends DcaReadingDataDefinitionBuilder
which has a static process
method which will create an instance.
Therefore the DIC defined parser from services.yml
will never get used.
How shall we proceed here?
Looks good so far. Just one thing which I guess that could be simplified.
IMO we should address some things regarding the MetaPalettesBuilder, it extends DcaReadingDataDefinitionBuilder which has a static process method which will create an instance. Therefore the DIC defined parser from services.yml will never get used. How shall we proceed here?
I'll have to take a deeper look how the definition builders are called by the DCG. Would it be possible use a service listener or is there no support for it at the moment?
I've started to rework the MetaPalettes extension to support Contao 4.4. Some refactoring to fullfill coding standards are yet missing:
PaletteManipulator
internally where possible.Some points should be discussed:
PaletteManipulator
? I vote against as it could be a shortcut. Besides removing fields is missing in thePaletteManipulator