search

contao-community-alliance / meta-palettes

Dynamic configured palettes for contao.
6 stars 8 forks source link

Check SubSelectPalettesListener if we can not work without DCA #46

Open zonky2 opened 2 years ago

zonky2 commented 2 years ago

my be..??

in https://github.com/contao-community-alliance/meta-palettes/blob/7a34d0ae2bca73ac649c4256853f82245e1bc5ec/src/Listener/SubSelectPalettesListener.php

see https://github.com/contao-community-alliance/meta-palettes/blob/7a34d0ae2bca73ac649c4256853f82245e1bc5ec/src/Listener/BuildPalettesListener.php#L65-L75

dmolineus commented 2 years ago

The SubSelectPalettesListener is only registered after the mentioned check above. So afaik it's not required adding the check again. https://github.com/contao-community-alliance/meta-palettes/blob/7a34d0ae2bca73ac649c4256853f82245e1bc5ec/src/Listener/BuildPalettesListener.php#L79

However #44 indicates that the DC General mix something up so that the issue occurs. Imho this has to be checked at the DC General site first, how #44 could ever happen. /cc @baumannsven