contao / check

Contao Check
GNU Lesser General Public License v3.0
47 stars 23 forks source link

[php.ini] Short tags #130

Closed ADoebeling closed 7 years ago

ADoebeling commented 7 years ago

I've recently got in trouble because a theme used php short tags that wasn't supported by the customer server.

AFAIK this is not a contao4-requirement, but a Notice would be great.

fritzmg commented 7 years ago

Do you mean <? ... ?>? What issues did you have with that? Having short tags enabled or disabled is not a basic requirement for Contao 3 or 4.

ADoebeling commented 7 years ago

Do you mean <? ... ?>?

yes

What issues did you have with that? Having short tags enabled or disabled is not a basic requirement for Contao 3 or 4.

yes but a theme we used required that feature to be enabled. If you don't want to add a section for additional and maybe usefull hints we should close this issue

fritzmg commented 7 years ago

The Contao Check does not check the requirements of various themes, just of Contao. It needs to be documented by the theme and not the Contao Check.

There are lots of other things that themes or extensions could require, that the Contao Check does not check for. It would make no sense to check or document those things in the Contao Check.

Aybee commented 7 years ago

Maybe he talks about.

<?= $this->foo ?>

I once also was on a server where this did not work. But it was a 2.11 installation, where I was coding a template with this short echo tag. I was wondering why this did not work and continued with

<?php echo $this->foo ?>

So I did not figure out the reason.

ADoebeling commented 7 years ago

@Aybee http://php.net/manual/en/language.basic-syntax.phptags.php

since php 5.4.0 | The tag <?= is always available regardless of the short_open_tag ini setting.

So this should work anyway

Aybee commented 7 years ago

Ah, ok. I also remembered the customer and I checked the version which realy is PHP 5.3.29 😳