search

contao / check

Contao Check
GNU Lesser General Public License v3.0
47 stars 23 forks source link

Live-Update check fails under certain conditions #59

Closed kikmedia closed 10 years ago

kikmedia commented 10 years ago

After a cheerful debate with Hosteurope support team we stumbled into an issue regarding detection of Phar streams.

In https://github.com/contao/check/blob/master/check/controller/live-update.php#L134 you are perfoming a check if Suhosin is enabled and Phar already whitelisted. Under certain conditions, that check fails because you don't check for phar streams.

In my opinion you shouldn't check for a string but for a stream, so code should perform if (in_array('phar://', array_map('trim', explode(',', $suhosin)))) . After that Phar will be detected correctly even if Suhosin is enabled.

leofeyer commented 10 years ago

Added in f7bfa41f142bc8d01e1e9c016eed8d4247e9529c.