contao / contao-demo

This is an example website for Contao, a powerful open source CMS that allows you to create professional websites and scalable web applications.
https://contao.org
Creative Commons Attribution Share Alike 4.0 International
3 stars 8 forks source link

QA and Frontend-fixes #1

Closed zoglo closed 1 year ago

zoglo commented 1 year ago

Information

These changes can be upstreamed to the 5.2.*-branch as it doesn't touch any files besides _table.scss (just consider the classname change in the 5.2 branch)


Fixes

This PR fixes following issues:

Always consider flex-wrap within mod_article 1ba8421338b01d0fad511a8fd80cc39b087a7709

This can lead to a lot of issues where every content will be shown in the same row. Not every browser (Chrome, Chromium-based, Safari) will break flex on default. EventsSocialMedia_Fix

Header-Image-Slider overflowing on mobile devices due to using a negative margin ff7959e5dfb613af2bd75c3c0ec1326f0ec298eb

I removed the margin-inline as it did break on mobile devices, you can see the initial version in this screenshot: Slider-Fix

Fixed events display on mobile devices 77f0fab153c731b05d39e898e04a1f2bceaeb756

The events calendar was broken completely on mobile devices due to the table styles, I added some revert styles to properly show the tables. (Imho, the media-breakpoints need a rework as there is lots of filesize to save)

EventsCalendar-Fix Overflow-Events-Fix Also the pseudo-element for tables: EventsCalendarPseudo-Fix

sascha-mueller commented 1 year ago

Let's talk about it at the conference. I would like to solve the tables differently and elsewhere the changed mod_article template causes the error.

zoglo commented 1 year ago

Let's talk about it at the conference. I would like to solve the tables differently and elsewhere the changed mod_article template causes the error.

I agree, this isn't a nice approach and the tables do break quite a few things.

I converted this Pull-Request to a draft for now

zoglo commented 1 year ago

Will close this in favor of the talk at the contao conference 2023.

Summary:

I'll provide another Draft with separate fixes soon