Rework search module - Githubissues

contao / contao-demo

This is an example website for Contao, a powerful open source CMS that allows you to create professional websites and scalable web applications.

https://contao.org

Creative Commons Attribution Share Alike 4.0 International

3 stars 8 forks source link

Rework search module #12

Closed zoglo closed 6 months ago

zoglo commented 1 year ago

Bugfixes

Fixes #3 c639d6dde53fc13f2b51d9ef69fcd145d20b538f
Fixes #8 e105594f56119829f3857a0adcc38fcc7a7606c2 03efe08ddde9257e37facba7a9ee847803381b59

Description

search icon is now clickable
removed pseudo-element and added background to button
do not display: none the search button (UX Improvement / Screenreader)
responsive search-form styles
added margin between search results

Screenshots

topsearch searchbar

de-es commented 8 months ago

@aschempp Spricht etwas gegen einen Merge? Bugfix approved. :grinning:

zoglo commented 8 months ago

@de-es Afaik, this could be also labeled as feature that fixes UX problems due to how the scss is written, especially with the calc in the media-query, hence demo-team that has to review this change. I don't think there's anything wrong implementing it in your project :)

sascha-mueller commented 8 months ago

The general solution is good. I would like to write it a little differently. Otherwise I would have merged it already. I didn't expect so much participation and I have to think about how to deal with it. First merge, then change as I would like. Or rather rewrite first, then merge.

zoglo commented 8 months ago

Or rather rewrite first, then merge.

Hey @sascha-mueller, you could either review in the codespace and suggest changes or you could commit directly into my branch (I always let maintainers do it when doing PRs)

You could also just tell me how you'd want it so I could implement it.