search

contao / contao-manager

Contao Manager
GNU Lesser General Public License v3.0
85 stars 33 forks source link

Use binary instead of Composer script handler #627

Closed aschempp closed 3 years ago

aschempp commented 3 years ago

The Managed Edition has already been updated (see https://github.com/contao/managed-edition/commit/3afc8e82ac83d0ee4bf31206c5d6b8e04ff052ba). Applying the change in the Contao Manager will be more challenging I guess, although the script handler still works and we would not have to adjust it.

Originally posted by @leofeyer in https://github.com/contao/contao/issues/2183#issuecomment-772306061

fritzmg commented 3 years ago

Some people are already trying to adjust it though, since the "Contao Manager" (actually Composer) tells them to do so: https://community.contao.org/de/showthread.php?80142-composer-json-%C3%84nderung-von-quot-post-update-cmd-quot-bringt-Fehler

m-vo commented 3 years ago

But manually adjusting the commands to point to contao-setup shouldn't be a problem, should it? (as long as you're not downgrading)

aschempp commented 3 years ago

Didn't we discuss not to add a warning because of that? 😆