Closed m-vo closed 3 years ago
I don't think this is how suggestions are supposed to work. In a regular package setup, suggestions are something that add additional features to the package if available. For example in Isotope, we suggest payment gateway APIs because the payment methods are implemented in Isotope, and if you install the API library they will be available automatically (simply through class_exists
).
I have created a pull request at https://github.com/twigphp/twig-extra-bundle/pull/3 to add suggestions to twigphp/twig-extra-bundle
. If the PR is approved, we can add twigphp/twig-extra-bundle
to our search index manually. If the package is installed (which is the default case in Contao 4.12), people can install the suggestions. It will also allow to install the bundle in Contao < 4.12 which will not work out-of-the-box, but maybe thats a limitation we can live with...
We have now added the twig packages to our own search index: https://github.com/contao/package-metadata/tree/main/meta/twig That required changing our search index because they (obviously) were top download and favs instantly 😂
I really like this solution! Thanks for adding it! :heart:
Moritz das war fast nur für Dich.
see https://github.com/contao/contao/pull/3228#issuecomment-890332730