zoglo
commented
4 months ago Multi-Step-Process
To be honest, this would be a multi-step process as most elements of the Contao Manager and package-list have to be touched.
We are talking about changing at least 14 files in the contao/package-list repository and at least 44 files in the contao/contao-manager repository.
I wouldn't feel comfortable to even remotely throw a PR that size at aschempp, unless slowly introducing custom properties within steps, then just adding the color-modes later on.
It shouldn't be just dark-mode but color-modes for A11Y
Imho a way too big change for just a dark-mode. If it's already such a big change, then going for multiple color modes should be the goal.
That also would raise the question if you'd build upon a known framework like bootstrap as many people could help (which already supports mult-color-modes Support and not just one extra dark-mode)
What I am thinking about is color-modes like:
- High contrast (Light/Dark) for bad eyes or a very bright environment
- Color modes for color blindness (Pro-, deuter- and tritanopia)
Where to start?
Either way, this should need to happen in contao/package-list first as the manager is dependent on the styles in there:
https://github.com/contao/package-list/tree/main/src/assets/styles so maybe opening an Issue about introducing custom-properties (that do not break any style) would be better.
Kinda 'annoying' to test
I don't see this happen soon unless there is:
- a good way to test every view and widget without having to click through everything
- enough time to review every style within the changed files (surely just talking about
It would be really cool if the manager had a DarkMode. 🥳