search

contao / contao-manager

Contao Manager
GNU Lesser General Public License v3.0
83 stars 33 forks source link

Also set the database version when storing the database credentials #705

Closed ausi closed 1 year ago

ausi commented 2 years ago

This is how the install tool does it currently: https://github.com/contao/contao/blob/2c914e74c29956612522911067d7bb1251d406cf/installation-bundle/src/Controller/InstallationController.php#L336-L346

See also https://github.com/contao/contao/pull/4158#issuecomment-1169685620

Not sure how to do this though, as the manager itself doesn’t connect to the database.

aschempp commented 2 years ago

Would it make sense to allow the user to select a database version? As far as I know it only matters between MySQL 5 and 8?

ausi commented 2 years ago

As far as I know it only matters between MySQL 5 and 8?

If this is the case, I’d agree that a select box for the user might make most sense :+1:

aschempp commented 1 year ago

Implemented in a4e084dcfe04ef55c458494c1ab89c6c1f4383f6.

mlwebworker commented 1 year ago

Ist es bei so einer Auswahlbox zwischen MySQL 5 und 8 nicht vom Verständnis her problematisch für alle User, die MariaDB benutzen oder habe ich bei Euch gerade etwas falsch verstanden?

fritzmg commented 1 year ago

Man wählt dann zwischen: