contao / contao-manager

Contao Manager
GNU Lesser General Public License v3.0
85 stars 33 forks source link

Custom table deletion default checked #739

Closed Kahmoon closed 1 year ago

Kahmoon commented 1 year ago

Hi,

the install tool marks the checkbox to delete tables by default. This behaviour is risky to accidently delete custom tables.

SCR-20221021-fkq

Greetz

ausi commented 1 year ago

As there is a backup of the database automatically before executing the migrations I’m not sure if this is considered risky.

fritzmg commented 1 year ago

I think it is, because if you lost data unnoticed, it will be at the very least inconvenient to restore and at worst impossible due to the backup retention policy.

Kahmoon commented 1 year ago

As there is a backup of the database automatically before executing the migrations I’m not sure if this is considered risky.

Didn´t know that. Where is this backup in case i would need it?

ausi commented 1 year ago

Where is this backup in case i would need it?

https://docs.contao.org/manual/de/cli/datenbank-backups/

Kahmoon commented 1 year ago

Where is this backup in case i would need it?

https://docs.contao.org/manual/de/cli/datenbank-backups/

I don´t want to create a backup (i already got one). I thought contao install tool will create automatically a backup when doing db updates :-D. Misunderstanding sorry :-)

fritzmg commented 1 year ago

As already said, Contao automatically creates a backup.

Kahmoon commented 1 year ago

OK? I misunderstood! I just did an update and at var/backups there is a backup. Now i get it :)

Toflar commented 1 year ago

Running contao:migrate does. So the Manager does as well.

aschempp commented 1 year ago

Running contao:migrate does. So the Manager does as well.

In Contao 4.13+ that is! Not for Contao 4.9 though. I will change the checkbox to be unchecked by default, since that's also the default behaviour of the command.

aschempp commented 1 year ago

Fixed in version 1.6.2