search

contao / contao-manager

Contao Manager
GNU Lesser General Public License v3.0
83 stars 33 forks source link

Use real version numbers for database configuration #740

Closed ausi closed 1 year ago

ausi commented 1 year ago

For better forwards compatibility with doctrine/dbal 4.0, see https://github.com/contao/conflicts/pull/38

In https://github.com/contao/contao-manager/blob/b84abfb4d24688324017455b6cc72031bf14234a/src/components/setup/DatabaseConnection.vue#L99-L114 we should use 8.0.0, 5.7.9, 10.2.7-MariaDB and 5.1.0

aschempp commented 1 year ago

are these compatible with older versions of Doctrine as well?

leofeyer commented 1 year ago

Yes, they are. The unit tests cover these version strings already.

https://github.com/morozov/dbal/blob/3.3.x/tests/Driver/AbstractMySQLDriverTest.php#L62 (Version 3.3.x)

aschempp commented 1 year ago

Fixed in version 1.6.2