search

contao / contao-manager

Contao Manager
GNU Lesser General Public License v3.0
83 stars 33 forks source link

Displaying an error when HTTP 401 #786

Closed zonky2 closed 4 months ago

zonky2 commented 8 months ago

In case of an authentication error (401) a green check mark is currently displayed although an update was not possible.

A red cross would be a better feedback here.

> Resolving dependencies using Composer Cloud v3.6.0-1-g9d9036c
[8.0MiB/0.20s] Loading composer repositories with package information
[8.5MiB/0.52s] <warning>https://token:geheim@packages.packmanager.de/r could not be fully loaded (The 'https://token:geheim@packages.packmanager.de/r/packages.json' URL required authentication (HTTP 401).
You must be using the interactive console to authenticate), package information was loaded from the local cache and may be out of date</warning>
...
aschempp commented 8 months ago

I don't understand what you're trying to suggest. Looks like a warning in your log, the task did not fail though?

zonky2 commented 8 months ago

The task could not be executed (401) and since the display is collapsed, you can't see that. There it would be surely better to show another icon than "everything o.k.!"

aschempp commented 8 months ago
https://token:geheim@packages.packmanager.de/r could not be fully loaded

This is a warning. Maybe the package could be loaded from somewhere else. The process must have been successful, otherwise it would have been reported as an error?

zonky2 commented 8 months ago

The process must have been successful, otherwise it would have been reported as an error?

No!

aschempp commented 7 months ago

I'm sorry I can't really help with this limited information. I would need to see at least some output to guess what you're trying to say 🤷