contao / contao-manager

Contao Manager
GNU Lesser General Public License v3.0
86 stars 33 forks source link

Scrollbar in the package detail view #815

Closed contaoacademy closed 4 months ago

contaoacademy commented 4 months ago

Depending on how many tabs are displayed in the detail view, the scrollbar may be visible. In the following example, you see the manager-bundle in the German language.

Perhaps this view can be optimized. screen-20240702_ioEHaTl8

aschempp commented 4 months ago

The scrolling is intentional, but on my browser the bar looks much better. Didn't think of other browsers, this sure should be optimized 🙈

zoglo commented 4 months ago

@contaoacademy could you tell me what OS and browser you are using?

contaoacademy commented 4 months ago

MacOS and Firefox or Brave Looks the same with both browsers

However, as already mentioned, this only occurs if the width is insufficient

Although I don't think it's really bad, because in 90% of cases the scrollbar is never visible. In my specific case it would be sufficient to reduce the margin of the individual tabs from 2px to 1px.

zoglo commented 4 months ago

@aschempp @contaoacademy How about a width of 800px (instead of 750px): image

This would have to be fixed in the package-list tho

aschempp commented 4 months ago

This would only solve the issue for german, but we are multilingual ;)

zoglo commented 4 months ago

But Germans usually use the longest words :D. Should we go with custom scrollbar styles then?

Thought that Mac doesn't show scrollbars anymore after a few seconds (showing on hover tho) and it's a system setting you have to opt-in to always show it again.

fritzmg commented 4 months ago

In Windows it looks like this:

image

imho it should may be work the same way as the new fieldset links in the contao back end editing view.

zoglo commented 4 months ago

imho it should may be work the same way as the new fieldset links in the contao back end editing view.

@fritzmg can you provide a screenshot of this example?

fritzmg commented 4 months ago

Just edit a record in Contao 5.3 :)

It uses

overflow-x: scroll;
scrollbar-width: none;

which means you can only scroll via touch, gestures or the middle mouse button.

zoglo commented 4 months ago

Just edit a record in Contao 5.3 :)

It uses

overflow-x: scroll;
scrollbar-width: none;

which means you can only scroll via touch, gestures or the middle mouse button.

But that would be bad UX since you can't really see that you could scroll.

You did use a vw of < 800px to take your screenshot, right? Just wondering if there is still devices out there that use that width

fritzmg commented 4 months ago

But that would be bad UX since you can't really see that you could scroll.

imho that's negligible in this case

Just wondering if there is still devices out there that use that width

Browsers can be any width, it's not about devices. And smartphones have a width smaller than 800px for sure.

zoglo commented 4 months ago

And smartphones have a width smaller than 800px for sure. Changing it to scrollbar-width: none; would also hide it on smartphones -> And some people actually look at extensions on their phone and this is a change happening in the package-list (thus on extensions.contao.org as well).

I was thinking more of a solution that would add a pseudoelement covering the scrollable area with a linear-gradient. Lemme just propose that in a PR so you'll see what I mean.

fritzmg commented 4 months ago

You will always see that something is cut off and then try to scroll imho. After all, that's what you do with regular content too. But a linear gradient to indicate something scrollable certainly will not hurt.

zoglo commented 4 months ago

You will always see that something is cut off and then try to scroll imho

You said it yourself that browsers can be any width. In specific cases, you won't see that something is cut off.

But a linear gradient to indicate something scrollable certainly will not hurt.

👍

zoglo commented 4 months ago

See: https://github.com/contao/package-list/pull/14

aschempp commented 4 months ago

Fixed in 5ed70869e23cbfc5a3a6d439daee4440d86b1c2f