search

contao / contao

Contao Open Source CMS
https://contao.org
GNU Lesser General Public License v3.0
337 stars 159 forks source link

Add a note about the CSS class "block" in UPGRADE.md #7329

Open contaoacademy opened 1 month ago

contaoacademy commented 1 month ago

Affected version(s)

5.3.x

Description

When updating from Contao 4 to 5, the additional class block is removed from the content elements. In combination with the old CSS framework, this can lead to display problems and reworking.

No problem so far. The only question is whether a note should be included in the upgrade.md.

Maybe add an addition to this part? https://github.com/contao/contao/blob/5.x/UPGRADE.md#css-classes-first-last-even-and-odd

fritzmg commented 1 month ago

In combination with the old CSS framework, this can lead to display problems and reworking.

That would be a bug that needs to be fixed in the CSS framework then.

iirc the block class was used as a clear fix, which is important for the legacy grid framework.

contaoacademy commented 1 month ago

In the layout.css you could find this statement:

/**
 * Clear floats
 */
.block {
    overflow:hidden;
}