search

contao / core-bundle

[READ-ONLY] Contao Core Bundle
GNU Lesser General Public License v3.0
123 stars 58 forks source link

Added support for subpalettes in personal profile #1559

Closed Toflar closed 6 years ago

Toflar commented 6 years ago

The problem is that Backend executes $this->objAjax->executePostActions($dc); before the callback of the registered module is called. Actually not even before but it doesn't call the callback at all if there are ajax requests. So basically no ajax operation can work which is why I removed the callback which was not necessary anyway and put it into a onload_callback which is what I would do in a custom module anyway.

This means anything that's possible in a regular DC is now possible in the back end user profile as well.

Fixes https://github.com/contao/core-bundle/issues/1552

Toflar commented 6 years ago

Fixed in https://github.com/contao/core-bundle/pull/1559/commits/52cca135d4bab35a03d4918011fafb0842496874.

Toflar commented 6 years ago

Yeah I thought about that but I just couldn't come up with any valid use case why one would have ever done that. And even if we'd leave the class there, nothing would happen because the callback is not called anymore so...

bytehead commented 6 years ago

Ok, fine for me then.

leofeyer commented 6 years ago

Thank you @Toflar.