search

contao / core-bundle

[READ-ONLY] Contao Core Bundle
GNU Lesser General Public License v3.0
123 stars 58 forks source link

Add "crossorigin" attribute to <img> tags #1617

Closed Toflar closed 6 years ago

Toflar commented 6 years ago

After reading https://cloudfour.com/thinks/when-7-kb-equals-7-mb/ I wonder if we should add the attribute to all our templates?

Wdyt?

/cc @may17

ausi commented 6 years ago

Most images in Contao are loaded from the same origin I think. And if they are loaded from a CDN the crossorigin attribute might break the images if the CDN is not configured to allow CORS.

may17 commented 6 years ago

Whats about the files / assets url on root Pages? That urls could be affected or am i wrong?

leofeyer commented 6 years ago

They could.

We have discussed this in Mumble on August 30th and given the possible issues mentioned above, we have decided to close this ticket.