contao / core-bundle

[READ-ONLY] Contao Core Bundle
GNU Lesser General Public License v3.0
123 stars 58 forks source link

[RFC] Check if service or alias exists before trying to make it public #1631

Closed sheeep closed 6 years ago

sheeep commented 6 years ago

The lexik/LexikMaintenanceBundle is only required by require-dev, which is therefore not installed when omitting the --dev in the installation process. Without a check in theMakeServicePublicPass the cache:clear command will fail with an exception.

You have requested a non-existent service "lexik_maintenance.driver.factory

By checking if the service exists beforehand, we can skip non existent services and aliases.

leofeyer commented 6 years ago

Thank you @sheeep.