search

contao / core-bundle

[READ-ONLY] Contao Core Bundle
GNU Lesser General Public License v3.0
123 stars 58 forks source link

Allow usage of Doctrine Entities for DCAs #1665

Closed m-vo closed 6 years ago

m-vo commented 6 years ago

When DcaSchemaProvider->createSchemaFromOrm() gets executed in the install tool, the appendToSchema() listener adds Contao's DCA SQL definitions to the schema. So far so good but, imho it must skip DCAs that have the same table name like any of the defined entities.

Why is this needed? Define a DCA like normal, but omit the SQL definitions. Define a doctrine entity that reflect the fields with the proper types and table name to match the dca. It's basically: Use entites instead of Contao models (but keep the DCA functionality) - it would be extremly helpful when wriring extensions.

Right now this leads to a SchemaException:

The table with name 'contao.tl_my_table' already exists.

The PR adds a check that eventually skips tables. It should not break anything as it only affects the install tool and those cases where an exception would have been thrown anyway.

Any objections? Or do I use a wrong approach? :smiley:

Just thinking: ... I'd actually consider this a bug. PR should then probably be targeted against the LTS branch. But let's hear your feedback first.

aschempp commented 6 years ago

I don't think this should be merged, as it would silently ignore some definitions. Simply do not add any SQL definitions to your DCA but only to your Doctrine entities and everything works fine.

m-vo commented 6 years ago

Should it? In my case the same error like stated above gets thrown.

m-vo commented 6 years ago

Debugged it. Turned out I had an index defined in on of the dca which I kept overlooking. :man_facepalming:

Ok, fine, then this could be closed. We need to document this anywhere...

fritzmg commented 6 years ago

We need to document this anywhere...

@netzarbeiter and I are on it ;). Once we have the basic, you can help document it :D