Fix backend system font stack for IE 11

contao / core-bundle

[READ-ONLY] Contao Core Bundle

GNU Lesser General Public License v3.0

123 stars 58 forks source link

Closed loilo closed 4 years ago

loilo commented 4 years ago

The native font stack introduced to the Contao backend in 67b8e7d breaks in Internet Explorer 11, resulting in the browser default font to be loaded.

Contao backend with serif font in IE 11

The cause is the fonts being part of a font shorthand property (which seems to be a known issue).

The PR fixes this behavior by moving the font face out of the font shorthand property into its own font-family.

bytehead commented 4 years ago

Thank you! This is the wrong repository (read only), PR should be done at https://github.com/contao/contao :)

loilo commented 4 years ago

Oh. I thought this only was the case with issues. Well that makes way more sense now I guess. 🙈

So should I just open up the PR over there?

bytehead commented 4 years ago

No worries! Yes please.

loilo commented 4 years ago

Out of curiosity: Why? Is this a split-off for updating Composer?

bytehead commented 4 years ago

Afaik to use the contao/core-bundle as a single bundle in your Symfony application instead of the whole contao/contao collection.

loilo commented 4 years ago

Sounds reasonable. Alright, brb with the right PR in the right place. 😁

bytehead commented 4 years ago

Base your pull request against the 4.8 branch at contao/contao (as it is a bugfix).