search

contao / core-bundle

[READ-ONLY] Contao Core Bundle
GNU Lesser General Public License v3.0
123 stars 58 forks source link

Allow value 0 in includeBlankOption - fix issue 1022 #1716

Closed zonky2 closed 3 years ago

zonky2 commented 3 years ago

Allow value 0 in includeBlankOption - fix issue #1022

see https://github.com/contao/contao/issues/1022#issuecomment-575210705

m-vo commented 3 years ago

I think we should add some tests for this change to see if it supports all edge cases.

Plus I'd target this against master (4.11). I don't think we should risk breaking 4.4 onwards.

m-vo commented 3 years ago

Oh, and I didn't notice this before: You PR should target contao/contao not contao/core-bundle.

zonky2 commented 3 years ago

shit - can I change it online? I did the PR directly on gitlab...

ausi commented 3 years ago

Closed in favor of contao/contao#2350

zonky2 commented 2 years ago

I don't really understand why the PR is closed - so far the behaviour is unchanged...

see https://github.com/menatwork/contao-multicolumnwizard-bundle/issues/63 - I would like to close that issue

@stefanheimes @ausi

ausi commented 2 years ago

I don't really understand why the PR is closed

It was closed in favor of contao/contao#2350

zonky2 commented 2 years ago

entweder stehe ich auf dem Schlauch oder verstehe es nicht - warum ist #2350 geschlossen?!?

das Problem ist bisher nicht gefixt!

ausi commented 2 years ago

warum ist #2350 geschlossen?!?

See https://github.com/contao/contao/pull/2350#issuecomment-735695944 :

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

You can answer the open questions and address the comments to get it reopened.