contao / core

Contao 3 → see contao/contao for Contao 4
GNU Lesser General Public License v3.0
490 stars 213 forks source link

Modulize the Maintenance Module #2989

Closed ghost closed 12 years ago

ghost commented 12 years ago

Attachet a ProofOfConcept for modulizing the ModuleMaintenance. Therefore it is able to add module specific content to the Maintenance page.

Including a preMaintenanceOutput Hook, when resorting or anything else is necessary.

Download the attachments

--- Originally created by lindesbs on April 5th, 2011, at 01:11pm (ID 2989)

ghost commented 12 years ago

Like it. But please make ModuleMaintenance_Generic an abstract class and call it AbstractModuleMaintenance or better (Abstract)MaintenanceAction (because it has nothing todo with "Module", which is mostly used for frontend modules in contao terminology)

--- Originally created by backbone on April 5th, 2011, at 10:38pm

leofeyer commented 12 years ago

What is it for?

--- Originally created on April 6th, 2011, at 06:20pm

ghost commented 12 years ago

If there is a module, who needs special maintenance tasks (recreating indexes, rebuild structures) these modules have to implement the possibility by themselves.

With this hook, they are able to add it to the normal COntao Maintenance Area, is quite easier to arrange same behaviours as leave it anywhere else in the modules.

It is just to simplify to working process for the BE Admin.

str_replace("Ring","Menupoint","One Ring to rule them all, One Ring to find them,");

;-)

--- Originally created by lindesbs on April 6th, 2011, at 06:56pm

Toflar commented 12 years ago

It's all about centralizing the whole maintenance data. Currently you can't just extend the ModuleMaintenance.php. It would be nice if the extension developers had a way to hook upon the module so they can provide their own maintenance routines. From the user's point of view this is a lot easier as he/she knows that everything is in "Maintenance" rather than e.g a global operation in module x, a runonce in module y, an own navigation point in module z etc.

It would even be nice if the maintenance screen was split up in sections so you have a maintenance section "Core", "Catalog", "Isotope" etc. that you can expand and collapse =) BTW: I started this thread in the "Entwickler-Interna" in the forum, if you want to discuss about it in more detail - just to let you know =)

--- Originally created on April 7th, 2011, at 09:21am

ghost commented 12 years ago

Do you need more input ? The issue is still in pending state.

--- Originally created by lindesbs on April 8th, 2011, at 03:47pm

ghost commented 12 years ago

I could branch the 2.10 with this patch including a more usable dashboard.

Its your choice.

--- Originally created by lindesbs on May 11th, 2011, at 09:18am

leofeyer commented 12 years ago

Implemented in 9c232b5423f04a77cecc33c7bd4a4f8b.

--- Originally created on June 23rd, 2011, at 03:42pm

Toflar commented 12 years ago

Excellent work!

--- Originally created on June 24th, 2011, at 08:24am

leofeyer commented 12 years ago

--- Originally completed on June 23rd, 2011, at 03:42pm