search

contao / core

Contao 3 → see contao/contao for Contao 4
GNU Lesser General Public License v3.0
490 stars 213 forks source link

hierarchical comments (tree comments) feature #3858

Closed DVeris closed 12 years ago

DVeris commented 12 years ago

hierarchical comments (tree comments) and numeration

qzminski commented 12 years ago

+1

leofeyer commented 12 years ago

Do we really need hierarchical comments? Doesn't a "notify me of subsequent comments" field suffice? Of course with an option to unsubscribe.

danielritter commented 12 years ago

I think: Yes, we do.

DVeris commented 12 years ago

http://www.contao.org/en/extension-list/view/notify_commentators.10000019.en.html (add unsubscribe) - yes

hierarchical comments - maybe not need but need numeration! 1. 2. 3. ... and link target on comment (for example 1.) css a.comm:target {background:red;}

lionel-m commented 12 years ago

I think hierarchical comments are useful.

For example with this link, a user can answer to a comment : http://webdesign.tutsplus.com/tutorials/htmlcss-tutorials/quick-tip-create-a-rating-system-with-css-web-fonts-and-sprites/#div-comment-36962

qzminski commented 12 years ago

Herarchical comments are almost a must-have feature. They could be developed as a separate extension, but it has to be done. I have encountered several cases where the nested comments were necessary, and so those people resigned from Contao. It's a pity to lose users just because we do not offer this little feature, whereas most of the other cmses have it built-in. So +1 again.

leofeyer commented 12 years ago

I have added the "notify me of new comments" option in 21759502db66d500fae7e364d1b4dc7687be4cf7 (feature branch). The module does not yet handle moderated comments which are published later in the back end.

leofeyer commented 12 years ago

Please check 47e24f283fc703341f103292da785f4384149f4f - the feature should be complete now.

DVeris commented 12 years ago

on local machine (easyphp + smtp4dev)

error

[03-Aug-2012 09:35:13 UTC] PHP Fatal error: Uncaught exception 'Swift_RfcComplianceException' with message 'Address in mailbox given [] does not comply with RFC 2822, 3.6.2.' thrown in H:\ctest.ru\system\library\Swiftmailer\classes\Swift\Mime\Headers\MailboxHeader.php on line 310

I have this problem was long ago. i was commenting 310-313 strings

notifications not sent only sent Contao :: New comment on ctest

leofeyer commented 12 years ago

This messages means that the e-mail address is not valid.

DVeris commented 12 years ago

i write comment like guest with ckeckbox then like member then like guest

notifications not sent

DVeris commented 12 years ago 
This messages means that the e-mail address is not valid.

yes, but I checked - emails are valid

DVeris commented 12 years ago

by the way

for me, when mail subject on russian

quoted-printable do not decoded

only when hotmail+windows live mail

:) why? why only when windows live mail receives mail from hotmail?)) if it google - working fine :)

leofeyer commented 12 years ago

Implemented in 586e39987bd41d3862788261fb56c7f0de40374e.

DVeris commented 12 years ago

why closed ? where hierarchical comments and numeration ? :)

leofeyer commented 12 years ago

For now, we (the Contao team) have decided to add only the "notify me of new comments" functionality. We'll see if we really need hierarchical comments.