search

contao / docs

Contao Documentation
https://docs.contao.org
Other
31 stars 150 forks source link

TopNavigation and sticky top-bar #1424

Closed fkaminski closed 1 month ago

fkaminski commented 1 month ago

Quickfix #1423

fritzmg commented 1 month ago

That makes the top bar jump though.

lukasbableck commented 1 month ago

The top bar also overlaps the search overlay a little bit now

image
fritzmg commented 1 month ago

@fkaminski should we revert https://github.com/contao/docs/pull/1416 and https://github.com/contao/docs/issues/1423 instead for the time being?

fkaminski commented 1 month ago

@fkaminski should we revert #1416 and #1423 instead for the time being?

As you like. We could fix the .DocSearch-Modal class with a custom top: 34px; too?

It would be better in the long term to remove the “jquery.sticky.js” and use a pure custom CCS solution. But the “jquery.sticky.js” is part of the theme partial (footer.html) and it would probably be more difficult to maintain it.

fritzmg commented 1 month ago

We could fix the .DocSearch-Modal class with a custom top: 34px; too?

I guess that will be sufficient. But I still don't like the sudden jump of the top bar.

fkaminski commented 1 month ago

... But I still don't like the sudden jump of the top bar.

Me too. But as mentioned, unfortunately we can currently only overwrite (css !important) the inline style from the theme script without touching the theme assets

fritzmg commented 1 month ago

Fixed in 65b47d6