search

contao / managed-edition

Contao Managed Edition
17 stars 14 forks source link

PHP 8 Compatibility #56

Closed ausi closed 3 years ago

ausi commented 3 years ago

Should we wait until contao/contao is compatible with PHP 8 before adding compatibility here?

aschempp commented 3 years ago

Imho we should remove it from this. The Contao Manager does not add a PHP dependency either, because the contao/manager-bundle should manage every dependency in a managed edition.

fritzmg commented 3 years ago

Isn't this root dependency there to optimise dependency resolving?

aschempp commented 3 years ago

in a regular PHP project, yes. But the Managed Edition is not a regular project, the composer.json should be the bare minimum and the contao/manager-bundle configures everything.

leofeyer commented 3 years ago

I have removed the PHP version requirement in the 4.9, 4.10 and the master branch.