Move plugin logic to core-bundle

contao / manager-bundle

[READ-ONLY] Contao Manager Bundle

GNU Lesser General Public License v3.0

17 stars 10 forks source link

Move plugin logic to core-bundle #13

Closed Toflar closed 7 years ago

Toflar commented 7 years ago

Most of the stuff listed in https://github.com/contao/manager-bundle/blob/develop/src/ContaoManager/Plugin.php should go to the core-bundle.

Toflar commented 7 years ago

See https://github.com/contao/manager-bundle/pull/14

leofeyer commented 7 years ago

I disagree. We need to distinguish between the core bundle and the standard edition here; and the core bundle must not configure anything but itself. The manager bundle is responsible for configuring the application, meaning everything that is configured in the standard edition.

Toflar commented 7 years ago

Yeah, but imho stuff that is in that plugin now, does not belong there. E.g. the KnpTimeBundle.

leofeyer commented 7 years ago

Yes, that's true.

aschempp commented 7 years ago

closed in favor of #18