contao / manager-bundle

[READ-ONLY] Contao Manager Bundle
GNU Lesser General Public License v3.0
17 stars 10 forks source link

use contao-console from package directly #15

Closed backbone87 closed 7 years ago

backbone87 commented 7 years ago

insteadof composers vender/bin one, because under windows these are launcher scripts for the package command and not symlinks of it

aschempp commented 7 years ago

Can anyone explain why composer adds these launcher scripts? They wouldn't be there if they were not useful for something?

backbone87 commented 7 years ago

thats just the way how composer treats binaries, if the binary relies on its location it would be no good to copy or link it from the bundle to the vendor/bin dir. so instead composer places launcher scripts in vendor/bin which will just call the real binary inside the package. this has also the benefit of providing a .bat for windows users.

there are basically 2 ways to call the binaries:

leofeyer commented 7 years ago

@backbone87 Does this apply here as well?

backbone87 commented 7 years ago

i dont think so because bin/console isnt a "third party binary" (binaries from vendor packages), but a real binary from the application (contao standard edition for example)

backbone87 commented 7 years ago

whats the difference between the contao-console and the symfony console? why arent there just contao commands for the symfony console? like php bin/console contao:do-something-fancy

edit: just checked that out, contao-console is something specific to managed edition where there is no bin/console?

aschempp commented 7 years ago

It is exactly the same, just another location.

aschempp commented 7 years ago

I still don't unterstand why we don't want to use the Composer script?

backbone87 commented 7 years ago

because its a shell script and not a php script

fritzmg commented 7 years ago

As mentioned in #25, could this be back ported into 4.3.11 please?