search

contao / manager-bundle

[READ-ONLY] Contao Manager Bundle
GNU Lesser General Public License v3.0
17 stars 10 forks source link

Implemented FirewallPluginInterface #31

Closed aschempp closed 7 years ago

aschempp commented 7 years ago

see #24

This solves the issue that security firewall configuration cannot be extended (cannotBeOverwritten is set on the TreeBuilder). I wonder if it would make sense to implement this as a general solution as we don't know if there are other such nodes?

aschempp commented 7 years ago

I have rewritten the implementation to use a more generic approach. The new ExtensionPluginInterface allows to process all extension configurations before they are used (basically, before they are processed by the extension).

This has several advantages:

  1. It's not specific to firewalls
  2. In regular cases, the interface is not needed at all
  3. It allows a plugin to modify all extension configuration from all bundles (even prepend), plugins and the application configuration itself.

The tests are currently failing because of #29